Skip to content

Commit ab5f892

Browse files
authoredFeb 8, 2023
fix: always display serialized error, even if it doesn't have stack (#2829)
1 parent 570c639 commit ab5f892

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed
 

‎packages/vitest/src/node/error.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,6 @@ function printStack(
188188
errorProperties: Record<string, unknown>,
189189
onStack?: ((stack: ParsedStack) => void),
190190
) {
191-
if (!stack.length)
192-
return
193-
194191
const logger = ctx.logger
195192

196193
for (const frame of stack) {
@@ -200,7 +197,8 @@ function printStack(
200197
logger.error(color(` ${c.dim(F_POINTER)} ${[frame.method, c.dim(`${path}:${frame.line}:${frame.column}`)].filter(Boolean).join(' ')}`))
201198
onStack?.(frame)
202199
}
203-
logger.error()
200+
if (stack.length)
201+
logger.error()
204202
const hasProperties = Object.keys(errorProperties).length > 0
205203
if (hasProperties) {
206204
logger.error(c.red(c.dim(divider())))

‎packages/vitest/src/utils/tasks.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export function hasBenchmark(suite: Arrayable<Suite>): boolean {
1010

1111
export function hasFailedSnapshot(suite: Arrayable<Task>): boolean {
1212
return getTests(suite).some((s) => {
13-
return s.result?.errors?.some(e => e.message.match(/Snapshot .* mismatched/))
13+
return s.result?.errors?.some(e => e && e.message && e.message.match(/Snapshot .* mismatched/))
1414
})
1515
}
1616

0 commit comments

Comments
 (0)
Please sign in to comment.