fix(vite-node): fix errors caused by commonjs export circular references (#3570)

Author: rxliuli

packages/vite-node/src/client.ts

@@ -330,7 +330,7 @@ export class ViteNodeRunner {
       set: (_, p, value) => {
         // treat "module.exports =" the same as "exports.default =" to not have nested "default.default",
         // so "exports.default" becomes the actual module
-        if (p === 'default' && this.shouldInterop(modulePath, { default: value })) {
+        if (p === 'default' && this.shouldInterop(modulePath, { default: value }) && cjsExports !== value) {
           exportAll(cjsExports, value)
           exports.default = value
           return true

pnpm-lock.yaml

@@ -9,7 +9,9 @@
     "debug": "node --inspect-brk ../../packages/vite-node/dist/cli.cjs"
   },
   "devDependencies": {
+    "@types/inquirer": "^9.0.3",
     "execa": "^6.1.0",
+    "inquirer": "^9.2.7",
     "vite-node": "workspace:*",
     "vitest": "workspace:*"
   }

test/vite-node/package.json

@@ -0,0 +1,9 @@
+// const ansiEscapes = module.exports
+// module.exports.default = ansiEscapes
+// ansiEscapes.HelloWorld = 1
+// console.log(ansiEscapes.HelloWorld);
+
+import inquirer from 'inquirer'
+
+// eslint-disable-next-line no-console
+console.log(inquirer.prompt)

test/vite-node/src/self-export-example1.ts

@@ -0,0 +1,4 @@
+import ansiEscapes, { HelloWorld } from './self-export'
+
+// eslint-disable-next-line no-console
+console.log(ansiEscapes, HelloWorld)

test/vite-node/src/self-export-example2.ts

@@ -0,0 +1,7 @@
+declare const ansiEscapes : {
+    HelloWorld: number
+}
+export default ansiEscapes
+
+declare const HelloWorld : number
+export { HelloWorld }

test/vite-node/src/self-export.d.ts

@@ -0,0 +1,3 @@
+const ansiEscapes = module.exports
+module.exports.default = ansiEscapes
+ansiEscapes.HelloWorld = 1

test/vite-node/src/self-export.js

@@ -0,0 +1,24 @@
+import { expect, it } from 'vitest'
+import { execa } from 'execa'
+import { resolve } from 'pathe'
+import ansiEscapes, { HelloWorld } from '../src/self-export'
+
+it('should export self', () => {
+  expect(ansiEscapes.HelloWorld).eq(HelloWorld)
+  expect(Reflect.get(ansiEscapes, 'default').HelloWorld).eq(HelloWorld)
+  expect(HelloWorld).eq(1)
+})
+
+const cliPath = resolve(__dirname, '../../../packages/vite-node/src/cli.ts')
+
+it('example 1', async () => {
+  const entryPath = resolve(__dirname, '../src/self-export-example1.ts')
+  const result = await execa('npx', ['esno', cliPath, entryPath], { reject: true })
+  expect(result.stdout).includes('Function')
+}, 60_000)
+
+it('example 2', async () => {
+  const entryPath = resolve(__dirname, '../src/self-export-example2.ts')
+  const result = await execa('npx', ['esno', cliPath, entryPath], { reject: true })
+  expect(result.stdout).includes('HelloWorld: 1').includes('default')
+}, 60_000)