fix(vite-node): external /dist/ by default

vitest-dev · Feb 18, 2022 · bb77e4f · bb77e4f
1 parent d8267ac
commit bb77e4f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/docs/config/index.md b/docs/config/index.md
@@ -57,7 +57,7 @@ Handling for dependencies inlining or externalizing
 #### deps.external
 
 - **Type:** `(string | RegExp)[]`
-- **Default:** `['**\/node_modules\/**']`
+- **Default:** `['**\/node_modules\/**','**\/dist\/**']`
 
 Externalize means that Vite will bypass the package to native Node. Externalized dependencies will not be applied Vite's transformers and resolvers, so they do not support HMR on reload. Typically, packages under `node_modules` are externalized.
 
@@ -372,4 +372,4 @@ Format options for snapshot testing.
 - **Type:** `string`
 - **Default:** `test`
 
-Overrides Vite mode.
+Overrides Vite mode.
diff --git a/packages/vite-node/src/externalize.ts b/packages/vite-node/src/externalize.ts
@@ -67,15 +67,15 @@ async function _shouldExternalize(
     return id
 
   const isNodeModule = id.includes('/node_modules/')
-
   id = isNodeModule ? guessCJSversion(id) || id : id
 
   if (matchExternalizePattern(id, defaultInline))
     return false
   if (matchExternalizePattern(id, depsExternal))
     return id
 
-  if (isNodeModule && await isValidNodeImport(id))
+  const isDist = id.includes('/dist/')
+  if ((isNodeModule || isDist) && await isValidNodeImport(id))
     return id
 
   return false

diff --git a/packages/vitest/LICENSE.md b/packages/vitest/LICENSE.md
@@ -465,6 +465,13 @@ Repository: git://github.com/kpdecker/jsdiff.git
 
 ---------------------------------------
 
+## eastasianwidth
+License: MIT
+By: Masaki Komagata
+Repository: git://github.com/komagata/eastasianwidth.git
+
+---------------------------------------
+
 ## emoji-regex
 License: MIT
 By: Mathias Bynens