From bb77e4f88a590fe5c34a6e3864b0ce0e87a609fe Mon Sep 17 00:00:00 2001 From: Anthony Fu Date: Fri, 18 Feb 2022 21:27:26 +0800 Subject: [PATCH] fix(vite-node): external `/dist/` by default --- docs/config/index.md | 4 ++-- packages/vite-node/src/externalize.ts | 4 ++-- packages/vitest/LICENSE.md | 7 +++++++ 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/docs/config/index.md b/docs/config/index.md index 5a76f88d38e0..83b35cbc749b 100644 --- a/docs/config/index.md +++ b/docs/config/index.md @@ -57,7 +57,7 @@ Handling for dependencies inlining or externalizing #### deps.external - **Type:** `(string | RegExp)[]` -- **Default:** `['**\/node_modules\/**']` +- **Default:** `['**\/node_modules\/**','**\/dist\/**']` Externalize means that Vite will bypass the package to native Node. Externalized dependencies will not be applied Vite's transformers and resolvers, so they do not support HMR on reload. Typically, packages under `node_modules` are externalized. @@ -372,4 +372,4 @@ Format options for snapshot testing. - **Type:** `string` - **Default:** `test` -Overrides Vite mode. \ No newline at end of file +Overrides Vite mode. diff --git a/packages/vite-node/src/externalize.ts b/packages/vite-node/src/externalize.ts index 4049b64f5dd1..bfce22bf50fe 100644 --- a/packages/vite-node/src/externalize.ts +++ b/packages/vite-node/src/externalize.ts @@ -67,7 +67,6 @@ async function _shouldExternalize( return id const isNodeModule = id.includes('/node_modules/') - id = isNodeModule ? guessCJSversion(id) || id : id if (matchExternalizePattern(id, defaultInline)) @@ -75,7 +74,8 @@ async function _shouldExternalize( if (matchExternalizePattern(id, depsExternal)) return id - if (isNodeModule && await isValidNodeImport(id)) + const isDist = id.includes('/dist/') + if ((isNodeModule || isDist) && await isValidNodeImport(id)) return id return false diff --git a/packages/vitest/LICENSE.md b/packages/vitest/LICENSE.md index 21b2e5607a42..61ece101cb73 100644 --- a/packages/vitest/LICENSE.md +++ b/packages/vitest/LICENSE.md @@ -465,6 +465,13 @@ Repository: git://github.com/kpdecker/jsdiff.git --------------------------------------- +## eastasianwidth +License: MIT +By: Masaki Komagata +Repository: git://github.com/komagata/eastasianwidth.git + +--------------------------------------- + ## emoji-regex License: MIT By: Mathias Bynens