fix: don't escape $ in snapshots, when not needed (#1401)

* fix: don't replace $ in snapshots, when not needed * test: remove \ in test
vitest-dev · May 31, 2022 · c5b7a72 · c5b7a72
1 parent b7bfc09
commit c5b7a72
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/packages/vitest/src/integrations/snapshot/port/inlineSnapshot.ts b/packages/vitest/src/integrations/snapshot/port/inlineSnapshot.ts
@@ -61,15 +61,14 @@ function prepareSnapString(snap: string, source: string, index: number) {
   const lines = snap
     .trim()
     .replace(/\\/g, '\\\\')
-    .replace(/\$/g, '\\$')
     .split(/\n/g)
 
   const isOneline = lines.length <= 1
   const quote = isOneline ? '\'' : '`'
   if (isOneline)
     return `'${lines.join('\n').replace(/'/g, '\\\'')}'`
   else
-    return `${quote}\n${lines.map(i => i ? indentNext + i : '').join('\n').replace(/`/g, '\\`')}\n${indent}${quote}`
+    return `${quote}\n${lines.map(i => i ? indentNext + i : '').join('\n').replace(/`/g, '\\`').replace(/\${/g, '\\${')}\n${indent}${quote}`
 }
 
 const startRegex = /(?:toMatchInlineSnapshot|toThrowErrorMatchingInlineSnapshot)\s*\(\s*[\w_$]*(['"`\)])/m

diff --git a/test/core/test/snapshot-inline.test.ts b/test/core/test/snapshot-inline.test.ts
@@ -19,6 +19,16 @@ test('object', () => {
 
 test('single line', () => {
   expect('inline string').toMatchInlineSnapshot('"inline string"')
+  expect('inline $ string').toMatchInlineSnapshot('"inline $ string"')
+  expect('inline multiline\n $string').toMatchInlineSnapshot(`
+    "inline multiline
+     $string"
+  `)
+  // eslint-disable-next-line no-template-curly-in-string
+  expect('inline multiline\n ${string}').toMatchInlineSnapshot(`
+    "inline multiline
+     \${string}"
+  `)
 })
 
 test('multiline', () => {