fix: don't terminate workers on Node 14 to not trigger fatal error (#2697)

sheremet-va · web-flow · commit db9b6bb74aa2 · 2023-01-18T14:40:23.000+01:00
diff --git a/packages/vitest/src/node/pool.ts b/packages/vitest/src/node/pool.ts
@@ -138,7 +138,10 @@ export function createPool(ctx: Vitest): WorkerPool {
   return {
     runTests: runWithFiles('run'),
     close: async () => {
-      await Promise.all(pool.threads.map(w => w.terminate()))
+      // node before 16.17 has a bug that causes FATAL ERROR because of the race condition
+      const nodeVersion = Number(process.version.match(/v(\d+)\.(\d+)/)?.[0].slice(1))
+      if (nodeVersion >= 16.17)
+        await Promise.all(pool.threads.map(w => w.terminate()))
     },
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,10 @@ export function createPool(ctx: Vitest): WorkerPool {`
`138`	`138`	`return {`
`139`	`139`	`runTests: runWithFiles('run'),`
`140`	`140`	`close: async () => {`
`141`		`- await Promise.all(pool.threads.map(w => w.terminate()))`
	`141`	`+ // node before 16.17 has a bug that causes FATAL ERROR because of the race condition`
	`142`	`+ const nodeVersion = Number(process.version.match(/v(\d+)\.(\d+)/)?.[0].slice(1))`
	`143`	`+ if (nodeVersion >= 16.17)`
	`144`	`+ await Promise.all(pool.threads.map(w => w.terminate()))`
`142`	`145`	`},`
`143`	`146`	`}`
`144`	`147`	`}`