Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error #1002

Merged
merged 1 commit into from Mar 23, 2022
Merged

fix: type error #1002

merged 1 commit into from Mar 23, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Mar 22, 2022

fix: #991

Does it look like typescript doesn't deeply compare two different modules(vitest / vitest/config)?

this PR make vitest/config deps vitest declare module and make it external vitest.

@netlify
Copy link

netlify bot commented Mar 22, 2022

✅ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: 4ee2e26

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6239a227444423000891ac8b

😎 Browse the preview: https://deploy-preview-1002--vitest-dev.netlify.app

@antfu antfu merged commit ce7927d into vitest-dev:main Mar 23, 2022
@poyoho poyoho deleted the fix/types-error branch March 23, 2022 06:11
chaii3 pushed a commit to chaii3/vitest that referenced this pull request May 13, 2022
Co-authored-by: Jelf <haichao.liang@parameters.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config.reporters: Type declaration conflicts
2 participants