Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower engines #1006

Merged
merged 1 commit into from Mar 23, 2022
Merged

fix: lower engines #1006

merged 1 commit into from Mar 23, 2022

Conversation

zephraph
Copy link
Contributor

Vercel uses aws lambda versions in it's build process. Currently the latest v14 version used by aws is v14.19.0. By raising to >=14.19.1 you prevent vercel builds from succeeding (until that cap is bumped).

See here for aws lambda version: https://docs.aws.amazon.com/elasticbeanstalk/latest/platforms/platform-history-nodejs.html

Note that I didn't touch the renvoate config. You likely don't want the engines version pinned to the latest patch version.

Vercel uses aws lambda versions in it's build process. Currently the latest v14 version used by aws is v14.19.0. By raising to `>=14.19.1` you prevent vercel builds from succeeding (until that cap is bumped). 

See here for aws lambda version: https://docs.aws.amazon.com/elasticbeanstalk/latest/platforms/platform-history-nodejs.html
@netlify
Copy link

netlify bot commented Mar 22, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit c9b7c64
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/623a4b75765c1f00080dd5b6
😎 Deploy Preview https://deploy-preview-1006--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu changed the title Lower engines so that vitest can be installed on vercel fix: lower engines Mar 23, 2022
@antfu antfu merged commit 68ed206 into vitest-dev:main Mar 23, 2022
@tafelnl
Copy link

tafelnl commented Mar 23, 2022

I think this fix should be applied to the vite-node package as well (this line)

I tried to deploy a site to vercel and got the following error:
error vite-node@0.7.9: The engine "node" is incompatible with this module. Expected version ">=v14.19.1". Got "14.19.0"

@tafelnl tafelnl mentioned this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants