Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): router plugin in ui #1007

Merged
merged 1 commit into from Mar 23, 2022
Merged

Conversation

craciuncezar
Copy link
Contributor

@craciuncezar craciuncezar commented Mar 23, 2022

With the latest update made here #590 I get this error in the UI

Screenshot 2022-03-23 at 11 00 10

This happens because we pass a router factory function to the app.use call instead of the actual router https://github.com/vitest-dev/vitest/blob/main/packages/ui/client/global-setup.ts#L22-L27

I'm new to Vue so I might be wrong here @JessicaSachs can you please take a look 🙏

close #1008

@netlify
Copy link

netlify bot commented Mar 23, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit da5182e
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/623ae55f765c1f000821884b
😎 Deploy Preview https://deploy-preview-1007--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@craciuncezar craciuncezar changed the title Fix router plugin in ui fix: router plugin in ui Mar 23, 2022
@antfu antfu changed the title fix: router plugin in ui fix(ui): router plugin in ui Mar 23, 2022
@antfu antfu merged commit c9f53f2 into vitest-dev:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router problem in UI
2 participants