Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router problem in UI #1008

Closed
6 tasks done
craciuncezar opened this issue Mar 23, 2022 · 0 comments · Fixed by #1007
Closed
6 tasks done

Router problem in UI #1008

craciuncezar opened this issue Mar 23, 2022 · 0 comments · Fixed by #1007

Comments

@craciuncezar
Copy link
Contributor

craciuncezar commented Mar 23, 2022

Describe the bug

With the latest update made here #590 I get this error in the UI

Screenshot 2022-03-23 at 11 00 10

This happens because we pass a router factory function to the app.use call instead of the actual router https://github.com/vitest-dev/vitest/blob/main/packages/ui/client/global-setup.ts#L22-L27

Reproduction

Run the UI in dev '⇧ ⌘ B' in VSCode

System Info

System:
    OS: macOS 12.2.1
    CPU: (4) x64 Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz
    Memory: 48.40 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.9.1 - /usr/local/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.5.0 - /usr/local/bin/npm
  Browsers:
    Brave Browser: 99.1.36.112
    Chrome: 99.0.4844.83
    Firefox: 95.0.2
    Safari: 15.3

Used Package Manager

pnpm

Validations

@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant