feat: show more details when no test files found #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dammy001
reviewed
Mar 26, 2022
packages/vitest/src/node/core.ts
Outdated
| if (this.config.passWithNoTests) | ||
| this.log('No test files found\n') | ||
| const exitCode = this.config.passWithNoTests ? 0 : 1 | ||
| if (this.config.passWithNoTests) { this.log(`No test files found, existing code with ${exitCode}\n`) } |
There was a problem hiding this comment.
Suggested change
| if (this.config.passWithNoTests) { this.log(`No test files found, existing code with ${exitCode}\n`) } | |
| if (this.config.passWithNoTests) { this.log(`No test files found, exiting code with ${exitCode}\n`) } |
sheremet-va
requested changes
Mar 27, 2022
docs/config/index.md
Outdated
| - **Type** `string | RegExp` | ||
|
|
||
| Run tests with full names matching the pattern. | ||
| If you add `do not run` to this property, tests containing the word `do not run` in the test name will be skipped. |
There was a problem hiding this comment.
I feel like the opposite will happen? Only tests containing "do not run" will run, no?
packages/vitest/src/utils/base.ts
Outdated
| * joinArrayItems | ||
| * convert Array<T> to a single string to display in stdout | ||
| */ | ||
| export function joinArrayItems(items: unknown[]): string { |
There was a problem hiding this comment.
just out of interest, what is the difference between just calling .join? I see all test cases will return the same if called with .join
There was a problem hiding this comment.
Fixed to use join since include and watchIgnore are absolutely the array. Thanks.
sheremet-va
approved these changes
Apr 2, 2022
chaii3
pushed a commit
to chaii3/vitest
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1032
Enable vitest to show
when no test files found.
