Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend config.outputFile to allow objects, close #1068 #1073

Merged
merged 5 commits into from Apr 7, 2022
Merged

feat: extend config.outputFile to allow objects, close #1068 #1073

merged 5 commits into from Apr 7, 2022

Conversation

steve-py96
Copy link
Contributor

@steve-py96 steve-py96 commented Apr 1, 2022 •
edited

related #1068

@netlify
Copy link

netlify bot commented Apr 1, 2022 •
edited

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit af0b496
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/624e8131fac72e0008c6c4f1
😎 Deploy Preview https://deploy-preview-1073--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@steve-py96 steve-py96 changed the title 1068 // extended config.outputFile to allow objects #1068 // extended config.outputFile to allow objects Apr 1, 2022
@steve-py96
Copy link
Contributor Author

note: I had (PR unrelated) errors when running nr test:all (on the main without changes)

errors:

test/fails test: ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 6 ⎯⎯⎯⎯⎯⎯⎯
    test/fails test:  FAIL  test/runner.test.ts > should fails > empty.test.ts
    test/fails test:  FAIL  test/runner.test.ts > should fails > expect.test.ts
    test/fails test:  FAIL  test/runner.test.ts > should fails > hook-timeout.test.ts
    test/fails test:  FAIL  test/runner.test.ts > should fails > nested-suite.test.ts
    test/fails test:  FAIL  test/runner.test.ts > should fails > stall.test.ts
    test/fails test:  FAIL  test/runner.test.ts > should fails > timeout.test.ts

@antfu antfu changed the title #1068 // extended config.outputFile to allow objects feat: extend config.outputFile to allow objects, close #1068 Apr 7, 2022
@antfu antfu merged commit a63cfa2 into vitest-dev:main Apr 7, 2022
@steve-py96 steve-py96 deleted the ISSUE-1068 branch April 7, 2022 19:27
@AriPerkkio AriPerkkio mentioned this pull request Apr 10, 2022
Merged
AriPerkkio added a commit to AriPerkkio/vitest-sonar-reporter that referenced this pull request Apr 10, 2022
@AriPerkkio
feat: support config.outputFile["vitest-sonar-reporter"] (#10)
ff8ea78 
- Enabled by vitest-dev/vitest#1073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriPerkkio AriPerkkio AriPerkkio left review comments

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@steve-py96 @AriPerkkio @sheremet-va @antfu