fix(logs): collect logs per test #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
userquin
commented
Apr 3, 2022
antfu
reviewed
Apr 4, 2022
edimitchel
suggested changes
Apr 4, 2022
edimitchel
approved these changes
Apr 4, 2022
sheremet-va
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context:
The log spy currently uses a single buffer to collect all the logs from all the tests, when sending the logs to the reporters, there is no way of knowing which tests each of the logs correspond to, so as soon as are sent, all the logs that are collected in the corresponding tick are shown as corresponding to the current test:
This PR also separates the timers by tests, since otherwise we can lose logs:
PR #1086 by @sheremet-va fixed the identifier of the test to which the collected logs belong, but when they are sent we still have the problem that all the ones in the buffer are sent, so the logs of other tests will be included under the running test at tick.
This PR includes the current logic but separated by test, so that the logs are collected and included in their own buffer and thus, when sent to the reporters the logs are shown where they belong:
and for ui (the tab title on console should be 4, fixed also in this PR):