Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): disabled icon buttons + codemirror scrolls + minor addons #1103

Merged
merged 1 commit into from Apr 5, 2022

Conversation

userquin
Copy link
Member

@userquin userquin commented Apr 5, 2022

This PR includes:

  • fix disabled on IconButton: avoid get focus when it is disabled, just configured the disabled prop on the button
  • added buttons for clearing search on navigation and suite panels. It also focus the input once cleared: the clear button on the task list also focus the input once clicked: https://streamable.com/ok3fa4 (on the video the button is shown/hidden, this PR just enable/disable the button)
  • fix codemirror scrolls, when scrolling (on click for scroll on thumb) the editor jumps (on horizontal scroll it has a huge impact): I included simplescrolls addon, it requires a resize observer to refresh the scrolls
  • fix min w/h for open in editor links on codemirror source code when error is present: https://streamable.com/kba255
  • make vertical scroll usable with mouse on thumb: the split left/top updated to 0 (right now with -10px, so the separator prevents use the scrolls, we only can use mouse wheel)

@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 3bd2010
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/624c3d4b23fef1000884d307
😎 Deploy Preview https://deploy-preview-1103--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu merged commit a1188b5 into main Apr 5, 2022
@antfu antfu deleted the userquin/fix-ui-minor-updates branch April 5, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants