Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add the draft state * on code editor #1131

Merged
merged 3 commits into from Apr 21, 2022
Merged

feat(ui): add the draft state * on code editor #1131

merged 3 commits into from Apr 21, 2022

Conversation

userquin
Copy link
Member

@userquin userquin commented Apr 9, 2022

The logic on the ViewEditor done, we only need to add the mark/decoration on the tab.

closes #1130

@netlify
Copy link

netlify bot commented Apr 9, 2022 •
edited

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 3b65724
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6251a9bd55c764000878535e
😎 Deploy Preview https://deploy-preview-1131--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin
Copy link
Member Author

userquin commented Apr 9, 2022 •
edited

I need to change draftref on ViewEditor to use v-model, the code right now works: https://streamable.com/kid87m

EDIT: just keep with the event approach

@edimitchel edimitchel added the feat: ui Vitest UI label Apr 12, 2022
@userquin userquin marked this pull request as ready for review April 18, 2022 19:45
@antfu antfu merged commit 571b94b into main Apr 21, 2022
@antfu antfu deleted the userquin/feat-ui-draft-state branch April 21, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat: ui Vitest UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: add the draft state * on code editor
3 participants
@userquin @edimitchel @antfu