JUnit reporter emits invalid XML when there are logs in stdout or stderr

[ciddan]

Describe the bug

The escapeXML function in the junit reporter does not remove characters that are illegal in an XML document. This can cause issues when writing lines from stdout and stderr to the output xml file.

There is an MIT licensed gist that correctly scrubs illegal characters. That, or something similar, should be added to the junit reporter.

I could write up an MR if you'd like.

Reproduction

Reproduction StackBlitz.

Let the tests run and open test_result/junit.xml. The file contains disallowed characters, specifically in the <system-err> tag.

You can use any XML validator to check, such as the one from w3schools.

System Info

System:
    OS: Linux 5.17 Fedora Linux 36 (Workstation Edition Prerelease)
    CPU: (16) x64 AMD Ryzen 7 4800U with Radeon Graphics
    Memory: 6.38 GB / 15.06 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v16.14.2/bin/yarn
    npm: 8.6.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
  Browsers:
    Chrome: 100.0.4896.75
    Firefox: 98.0.2
  npmPackages:
    vite: ^2.9.1 => 2.9.1 
    vitest: ^0.9.3 => 0.9.3

Used Package Manager

yarn

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[ciddan]

Opened PR #1145.