fix: replace root when resolving dependency #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sheremet-va
requested changes
May 20, 2022
| @@ -8,6 +8,10 @@ export function slash(str: string) { | |||
| return str.replace(/\\/g, '/') | |||
| } | |||
|
|
|||
| export function mergeSlashes(str: string) { | |||
There was a problem hiding this comment.
we already have this function in utils/base.ts
There was a problem hiding this comment.
The existing function is under vitest package. Should we reference this function across packages?
There was a problem hiding this comment.
Oh, I didn't notice. I guess no, we shouldn't. Maybe sometime we can create a utils package, but not in this issue, I think
sheremet-va
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1294.
the reason for this issue is that when we resolve all mocks, store them in
mockMap. it looks like below,but when we actually import, the incoming path is
@wdio/logger, it becomes/@fs/${rootPath}/node_modules/@wdio/logger/build/node.jsafterresolveIdfunction. so the mock fails.