Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function/promise forms of defineConfig() #1324

Merged
merged 1 commit into from May 17, 2022
Merged

feat: add function/promise forms of defineConfig() #1324

merged 1 commit into from May 17, 2022

Conversation

pastelmind
Copy link
Contributor

@pastelmind pastelmind commented May 17, 2022

Make defineConfig() accept a callback or promise that resolves to a config. This matches the signature of defineConfig() from Vite:

https://github.com/vitejs/vite/blob/0858450b2a258b216ae9aa797cc02e9a0d4eb0af/packages/vite/src/node/config.ts#L53-L64

Resolves #1301

Make `defineConfig()` accept a callback or promise that resolves to a config.
This matches the signature of `defineConfig()` from Vite.
@netlify
Copy link

netlify bot commented May 17, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 39de894
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6282e6754bb6ab000a807325
😎 Deploy Preview https://deploy-preview-1324--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu merged commit 5af545d into vitest-dev:main May 17, 2022
@pastelmind pastelmind deleted the patch-3 branch May 17, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defineConfig from vitest does not accept function
2 participants