Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toSatisfy never executes the matcher function #1350

Merged
merged 4 commits into from May 21, 2022
Merged

fix: toSatisfy never executes the matcher function #1350

merged 4 commits into from May 21, 2022

Conversation

ST-DDT
Copy link
Contributor

@ST-DDT ST-DDT commented May 21, 2022

This PR fixes #1172.

This was discovered in #1172 (comment) but never fixed.

@netlify
Copy link

netlify bot commented May 21, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 9b1323c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/628916e8c067cd00081d4e5b
😎 Deploy Preview https://deploy-preview-1350--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sheremet-va
Copy link
Member

This was discovered in #1172 (comment) but never fixed

I seems some people just want an illusion of test 👀

Copy link
Contributor

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing vi in import in line 3

@ST-DDT ST-DDT mentioned this pull request May 21, 2022
@antfu antfu merged commit 5654a88 into vitest-dev:main May 21, 2022
@ST-DDT ST-DDT deleted the fix/toSatisfy branch May 21, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants