Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dynamicImportSettled utility function #1359

Merged
merged 5 commits into from May 29, 2022
Merged

feat: add dynamicImportSettled utility function #1359

merged 5 commits into from May 29, 2022

Conversation

sheremet-va
Copy link
Member

Context #1328

@sheremet-va sheremet-va requested a review from antfu May 23, 2022 10:11
@netlify
Copy link

netlify bot commented May 23, 2022 •
edited

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit e8a2068
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/628b738f16edbf000a2fc237
😎 Deploy Preview https://deploy-preview-1359--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sheremet-va
Copy link
Member Author

@cexbrayat what do you think about this?

cexbrayat
cexbrayat approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great 👍

packages/vitest/src/integrations/vi.ts Outdated Show resolved Hide resolved
@antfu antfu merged commit 1793937 into vitest-dev:main May 29, 2022
@mustafadalga
Copy link

Thanks for feature :)

@sheremet-va sheremet-va deleted the feat/dynamic-import-settled branch January 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sheremet-va @mustafadalga @cexbrayat @antfu