Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/node to dependencies #1474

Merged
merged 2 commits into from Jun 13, 2022

Conversation

sheremet-va
Copy link
Member

@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ca60e14
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62a7140f84ea190008a54a5e
😎 Deploy Preview https://deploy-preview-1474--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sheremet-va sheremet-va requested a review from antfu June 13, 2022 09:37
@antfu
Copy link
Member

antfu commented Jun 13, 2022

But I am not very sure about the version range here. Ideally, we should respect users' @types/node if ever specified. So probably "@types/node": "*" in dependencies

@sheremet-va
Copy link
Member Author

But I am not very sure about the version range here. Ideally, we should respect users' @types/node if ever specified. So probably "@types/node": "*" in dependencies

Done :D

@sheremet-va sheremet-va merged commit 1012534 into vitest-dev:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails because of missing type definitions
2 participants