Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vite-node): vite hmr support #1516

Merged
merged 18 commits into from Jul 2, 2022
Merged

feat(vite-node): vite hmr support #1516

merged 18 commits into from Jul 2, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Jun 20, 2022 •
edited

fix: #1028
fork vite client hmr handle in vite-node

@netlify
Copy link

netlify bot commented Jun 20, 2022 •
edited

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 2465d7b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62bebe0287912b00081b83f5
😎 Deploy Preview https://deploy-preview-1516--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sheremet-va
sheremet-va reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we export a public interface for it, so people can reuse it? I mean, define an entry point in rollup.config and in exports in package.json

@antfu antfu changed the title feat: vite node hmr feat(vite-node): vite hmr support Jun 21, 2022
@poyoho
Copy link
Member Author

poyoho commented Jun 21, 2022 •
edited

FetchError: request to https://github.com/PuruVJ.png?size40 failed, reason: connect ETIMEDOUT ...

@sheremet-va sheremet-va merged commit 4a95177 into vitest-dev:main Jul 2, 2022
@poyoho poyoho deleted the vite-node/hmr branch July 2, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HMR not available in Vite-node
3 participants
@poyoho @antfu @sheremet-va