Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vite 3 support #1561

Merged
merged 9 commits into from Jun 27, 2022
Merged

feat: add vite 3 support #1561

merged 9 commits into from Jun 27, 2022

Conversation

sheremet-va
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 2dc6694
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62b9b23572e3ce000ba4a71b
😎 Deploy Preview https://deploy-preview-1561--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev
Copy link
Member

LGTM. I tried running with vite-ecosystem-ci, but it failed with the duplicated plugins errors: https://github.com/vitejs/vite-ecosystem-ci/runs/7074587165?check_suite_focus=true
I think this is due to the plugins. Since all tests are passing here, I think we should move forward and merge this PR so we start getting feedback from others (at least for the people working on PRs and checking main before the next release, and about how this works for Vite v2)

@patak-dev patak-dev merged commit edbf907 into main Jun 27, 2022
@patak-dev patak-dev deleted the feat/vite-3-now branch June 27, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants