-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: check related against forceRerunTriggers
#1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check related against forceRerunTriggers
#1595
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for lock file
893e559
to
aa0c36f
Compare
I don't think we have unit tests for those, but we have
|
Also, please, add more information to the docs of |
bb25f42
to
497c33c
Compare
forceRerunTriggers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elliotwestlake should we add new defaults to If yes, this should also be specified in docs. |
Great idea, will add them and any others I can think of! |
@sheremet-va @antfu Defaults added, ready to merge when you are |
Head branch was pushed to by a user without write access
@sheremet-va Any chance you could enable auto-merge again please? The checks weren't running with your commit for some reason |
If forceRerunTriggers has globs in it then we use
micromatch
to see if there's a file inrelated
that should trigger the whole test suiteWas going to write some tests for this, but not sure where they should go
Resolves: #1592