fix: mock properties of classes/functions (fix #1523) #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
6 tasks
|
Not quite ready yet. Found a problem with importing CJS modules. Will be fixed momentarily. |
Previously classes weren't mocked properly because their prototypes were not being copied, so they lost all their methods. This commit rewrites the automocker to properly handle: - Functions with properties (namely classes) - Circular objects (also to handle classes, thanks JavaScript) With these changes classes can now be properly automocked! This fixes vitest-dev#1523.
simon-abbott
force-pushed
the
fix-class-automocking
branch
from
a465428
to
1728548
Compare
|
CJS issue fixed, this PR is good to go. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously classes weren't mocked properly because their prototypes were not being copied, so they lost all their methods. This PR rewrites the automocker to properly handle:
With these changes classes can now be properly automocked!
This fixes #1523.