fix: importActual path resolution for non-child paths (fix #1864) #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-abbott
force-pushed
the
1864-fix-importActual-path-resolution
branch
from
2e9b335
to
1efdd2d
Compare
|
Ok I have no idea why that one CI run failed. If anyone knows please let me know so I can fix it! |
|
@antfu Could this be merged soon? This is completely blocking my ability to convert our application over to vitest. |
sheremet-va
requested changes
Aug 22, 2022
sheremet-va
requested changes
Aug 31, 2022
|
@simon-abbott We might try this approach anyway. Do you think you can resolve conflicts? |
|
Certainly! |
simon-abbott
force-pushed
the
1864-fix-importActual-path-resolution
branch
from
0ded073
to
47dab87
Compare
Previously `toFilePath` would treat _any_ absolute path that doesn't start with the `root` (usually the current working directory) as a relative path, which resulted in some seriously mangled paths. Now we actually check if that resolved path exists before committing to it. This fixes vitest-dev#1864.
simon-abbott
force-pushed
the
1864-fix-importActual-path-resolution
branch
from
47dab87
to
b18f707
Compare
fwouts
pushed a commit
to fwouts/previewjs
that referenced
this pull request
Oct 31, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vitest](https://togithub.com/vitest-dev/vitest) | [`0.24.3` -> `0.24.4`](https://renovatebot.com/diffs/npm/vitest/0.24.3/0.24.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.24.4`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.4) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.3...v0.24.4) ##### 🚀 Features - **vite-node**: Don't exit on uncaughtException in watch mode - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2186 ##### 🐞 Bug Fixes - Add/Update `repository` properties in `package.json` - by [@​silverwind](https://togithub.com/silverwind) in [vitest-dev/vitest#2151 - Ignore benchmark.reporters in getSerializableConfig - by [@​kainstar](https://togithub.com/kainstar) in [vitest-dev/vitest#2164 - Improve config's default exclude - by [@​haikyuu](https://togithub.com/haikyuu) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2188 - Always use node condition - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#1919 - Clear terminal output before running tests, show errors in correct order - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2228 - Improve compatibility with native Node CJS resolution - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2226 - Don't use resolved paths if they don't actually exist - by [@​simon-abbott](https://togithub.com/simon-abbott) in [vitest-dev/vitest#1868 - **cli**: - Set inputNamePattern to RegExp source instead of string - by [@​rafedramzi](https://togithub.com/rafedramzi) in [vitest-dev/vitest#2201 - Normalize argument path - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2180 - **coverage**: - Trim URL parameters from file paths in istanbul coverage - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2232 - Trim URL parameters from file paths in c8 coverage - by [@​OrestHk](https://togithub.com/OrestHk) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2181 - **reporter**: - Load custom reporter using `executeFile` - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2184 - **vitest**: - Return detailed error when using toHaveReturnedWith - by [@​azaleta](https://togithub.com/azaleta) in [vitest-dev/vitest#2163 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.3...v0.24.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC45LjIifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
6 tasks
1 task
ivarconr
pushed a commit
to Unleash/unleash
that referenced
this pull request
Nov 10, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vitest](https://togithub.com/vitest-dev/vitest) | [`0.24.3` -> `0.25.1`](https://renovatebot.com/diffs/npm/vitest/0.24.3/0.25.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.25.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.0...v0.25.1) ##### 🚀 Features - Add `vi.setConfig` helper - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2293 - Allow hooks to be executed in a stack or list - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2294 ##### 🐞 Bug Fixes - Always rewrite defined jsdom keys - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2290 - Default reporter regression - by [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2292 - Don't fail `bench` when using options - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2295 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.0...v0.25.1) ### [`v0.25.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.5...v0.25.0) ##### ✅ Builtin TypeChecking In v0.25.0, Vitest allows you to write tests for your types, using `expectTypeOf` or `assertType` syntaxes. By default all tests inside `*.test-d.ts` files are considered type tests. Run `vitest typecheck` to run type tests. ```ts // my.test-d.ts import { assertType, expectTypeOf } from 'vitest' import { mount } from './mount.js' test('my types work properly', () => { expectTypeOf(mount).toBeFunction() expectTypeOf(mount).parameter(0).toMatchTypeOf<{ name: string }>() // @​ts-expect-error name is a string assertType(mount({ name: 42 })) }) ``` Learn more at [the documentation](https://vitest.dev/guide/testing-types.html) and this [RFC](https://togithub.com/vitest-dev/vitest/issues/1954) ##### 🚨 Breaking Changes - Return context in `startVitest()` - by [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2072 ##### 🚀 Features - `onTestFailed` hook - by [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2210 - Display error frame if present (like Vite) - by [@​haikyuu](https://togithub.com/haikyuu) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2257 - Benchmark table report - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2179 - Add typechecking functionality - by [@​sheremet-va](https://togithub.com/sheremet-va) and [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2107 ##### 🐞 Bug Fixes - Clear full screen only in watch mode - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(c3d89)</samp>](https://togithub.com/vitest-dev/vitest/commit/c3d89504) - Don't serialize symbols and immutables - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2266 - Use --conditions instead of -C - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2267 - Show correct stack trace in errors and console - by [@​sheremet-va](https://togithub.com/sheremet-va) and [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2248 - Align `.each` behavior with jest - by [@​bartoszgolebiowski](https://togithub.com/bartoszgolebiowski) and [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2064 - Remove undefined values in options - by [@​g4rry420](https://togithub.com/g4rry420) and [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2281 - **coverage**: Istanbul provider to preserve implicit else - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2275 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.5...v0.25.0) ### [`v0.24.5`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.5) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.4...v0.24.5) ##### 🚀 Features - **vite-node**: Trigger beforeFullReload / beforePrune / invalidate hook - by [@​ycmjason](https://togithub.com/ycmjason) in [vitest-dev/vitest#2079 ##### 🐞 Bug Fixes - Respect folders with dot at the start, when mocking - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2244 - Prevent using mocks in rpc - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2254 - Show actual unhandled errors, serialize DOMErrors - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2253 - Load deps reporter - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2249 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.4...v0.24.5) ### [`v0.24.4`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.4) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.3...v0.24.4) ##### 🚀 Features - **vite-node**: Don't exit on uncaughtException in watch mode - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2186 ##### 🐞 Bug Fixes - Add/Update `repository` properties in `package.json` - by [@​silverwind](https://togithub.com/silverwind) in [vitest-dev/vitest#2151 - Ignore benchmark.reporters in getSerializableConfig - by [@​kainstar](https://togithub.com/kainstar) in [vitest-dev/vitest#2164 - Improve config's default exclude - by [@​haikyuu](https://togithub.com/haikyuu) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2188 - Always use node condition - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#1919 - Clear terminal output before running tests, show errors in correct order - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2228 - Improve compatibility with native Node CJS resolution - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2226 - Don't use resolved paths if they don't actually exist - by [@​simon-abbott](https://togithub.com/simon-abbott) in [vitest-dev/vitest#1868 - **cli**: - Set inputNamePattern to RegExp source instead of string - by [@​rafedramzi](https://togithub.com/rafedramzi) in [vitest-dev/vitest#2201 - Normalize argument path - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2180 - **coverage**: - Trim URL parameters from file paths in istanbul coverage - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2232 - Trim URL parameters from file paths in c8 coverage - by [@​OrestHk](https://togithub.com/OrestHk) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2181 - **reporter**: - Load custom reporter using `executeFile` - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2184 - **vitest**: - Return detailed error when using toHaveReturnedWith - by [@​azaleta](https://togithub.com/azaleta) in [vitest-dev/vitest#2163 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.3...v0.24.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTkuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
andipaetzold
pushed a commit
to andipaetzold/react-firehooks
that referenced
this pull request
Nov 25, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vitest/coverage-c8](https://togithub.com/vitest-dev/vitest) | [`0.24.3` -> `0.25.3`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-c8/0.24.3/0.25.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vitest](https://togithub.com/vitest-dev/vitest) | [`0.24.3` -> `0.25.3`](https://renovatebot.com/diffs/npm/vitest/0.24.3/0.25.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.25.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) ##### 🚀 Features - Test.each support string template - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2337 [<samp>(f7897)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7897765) ##### 🐞 Bug Fixes - Junit consistently puts "skipped" inside "testcase" - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(f7b27)</samp>](https://togithub.com/vitest-dev/vitest/commit/f7b27af0) - Detect tests in folders starting with `.` - by [@​sidharthv96](https://togithub.com/sidharthv96) in [vitest-dev/vitest#2344 and [vitest-dev/vitest#2359 [<samp>(c3951)</samp>](https://togithub.com/vitest-dev/vitest/commit/c395177f) - **cli**: Don't override config by setting cli options to undefined - by [@​rmehner](https://togithub.com/rmehner) in [vitest-dev/vitest#2330 [<samp>(6ce3e)</samp>](https://togithub.com/vitest-dev/vitest/commit/6ce3ed7f) - **coverage**: Env-replacer to add filenames into sourcemaps - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2338 [<samp>(a2e9d)</samp>](https://togithub.com/vitest-dev/vitest/commit/a2e9daf6) - **mocker**: Clear automocked modules on unmock - by [@​mcous](https://togithub.com/mcous) in [vitest-dev/vitest#2353 [<samp>(60918)</samp>](https://togithub.com/vitest-dev/vitest/commit/609185bd) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.2...v0.25.3) ### [`v0.25.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.2) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.1...v0.25.2) ##### 🐞 Bug Fixes - Dates are equal, if both are invalid - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2326 - Don't ignore properties, when put on a default function in CJS context - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2325 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.1...v0.25.2) ### [`v0.25.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.0...v0.25.1) ##### 🚀 Features - Add `vi.setConfig` helper - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2293 - Allow hooks to be executed in a stack or list - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2294 ##### 🐞 Bug Fixes - Always rewrite defined jsdom keys - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2290 - Default reporter regression - by [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2292 - Don't fail `bench` when using options - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2295 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.0...v0.25.1) ### [`v0.25.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.5...v0.25.0) ##### ✅ Builtin TypeChecking In v0.25.0, Vitest allows you to write tests for your types, using `expectTypeOf` or `assertType` syntaxes. By default all tests inside `*.test-d.ts` files are considered type tests. Run `vitest typecheck` to run type tests. ```ts // my.test-d.ts import { assertType, expectTypeOf } from 'vitest' import { mount } from './mount.js' test('my types work properly', () => { expectTypeOf(mount).toBeFunction() expectTypeOf(mount).parameter(0).toMatchTypeOf<{ name: string }>() // @​ts-expect-error name is a string assertType(mount({ name: 42 })) }) ``` Learn more at [the documentation](https://vitest.dev/guide/testing-types.html) and this [RFC](https://togithub.com/vitest-dev/vitest/issues/1954) ##### 🚨 Breaking Changes - Return context in `startVitest()` - by [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2072 ##### 🚀 Features - `onTestFailed` hook - by [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2210 - Display error frame if present (like Vite) - by [@​haikyuu](https://togithub.com/haikyuu) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2257 - Benchmark table report - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2179 - Add typechecking functionality - by [@​sheremet-va](https://togithub.com/sheremet-va) and [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2107 ##### 🐞 Bug Fixes - Clear full screen only in watch mode - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(c3d89)</samp>](https://togithub.com/vitest-dev/vitest/commit/c3d89504) - Don't serialize symbols and immutables - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2266 - Use --conditions instead of -C - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2267 - Show correct stack trace in errors and console - by [@​sheremet-va](https://togithub.com/sheremet-va) and [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2248 - Align `.each` behavior with jest - by [@​bartoszgolebiowski](https://togithub.com/bartoszgolebiowski) and [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2064 - Remove undefined values in options - by [@​g4rry420](https://togithub.com/g4rry420) and [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#2281 - **coverage**: Istanbul provider to preserve implicit else - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2275 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.5...v0.25.0) ### [`v0.24.5`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.5) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.4...v0.24.5) ##### 🚀 Features - **vite-node**: Trigger beforeFullReload / beforePrune / invalidate hook - by [@​ycmjason](https://togithub.com/ycmjason) in [vitest-dev/vitest#2079 ##### 🐞 Bug Fixes - Respect folders with dot at the start, when mocking - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2244 - Prevent using mocks in rpc - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2254 - Show actual unhandled errors, serialize DOMErrors - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2253 - Load deps reporter - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2249 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.4...v0.24.5) ### [`v0.24.4`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.4) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.3...v0.24.4) ##### 🚀 Features - **vite-node**: Don't exit on uncaughtException in watch mode - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2186 ##### 🐞 Bug Fixes - Add/Update `repository` properties in `package.json` - by [@​silverwind](https://togithub.com/silverwind) in [vitest-dev/vitest#2151 - Ignore benchmark.reporters in getSerializableConfig - by [@​kainstar](https://togithub.com/kainstar) in [vitest-dev/vitest#2164 - Improve config's default exclude - by [@​haikyuu](https://togithub.com/haikyuu) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2188 - Always use node condition - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#1919 - Clear terminal output before running tests, show errors in correct order - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2228 - Improve compatibility with native Node CJS resolution - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2226 - Don't use resolved paths if they don't actually exist - by [@​simon-abbott](https://togithub.com/simon-abbott) in [vitest-dev/vitest#1868 - **cli**: - Set inputNamePattern to RegExp source instead of string - by [@​rafedramzi](https://togithub.com/rafedramzi) in [vitest-dev/vitest#2201 - Normalize argument path - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2180 - **coverage**: - Trim URL parameters from file paths in istanbul coverage - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2232 - Trim URL parameters from file paths in c8 coverage - by [@​OrestHk](https://togithub.com/OrestHk) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2181 - **reporter**: - Load custom reporter using `executeFile` - by [@​poyoho](https://togithub.com/poyoho) in [vitest-dev/vitest#2184 - **vitest**: - Return detailed error when using toHaveReturnedWith - by [@​azaleta](https://togithub.com/azaleta) in [vitest-dev/vitest#2163 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.3...v0.24.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/andipaetzold/react-firehooks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC4zMC4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two similar bugs with
importActual's path resolution:importActualmangles file paths when importing sister packages in Lerna repos #1864, importing from sibling directories would try to import from sub directories instead.path = '/foo/bar-baz'withroot = '/foo/bar'results in an output of-baz)Fixes #1864.