fix(reporter-junit): escape XML when in error message (fix: #1823) #1890
+116
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisTowles
force-pushed
the
chris-towles/fix-junit-when-xml-in-error-message
branch
2 times, most recently
from
d29d4ce to
8c4aa9a
Compare
…ue to windows failed test
ChrisTowles
force-pushed
the
chris-towles/fix-junit-when-xml-in-error-message
branch
from
8c4aa9a to
0673943
Compare
|
Windows Tests was flakey, It broke 3 times with different errors seemingly not related to this change. I force pushed a no-op change and it worked last time.... |
Demivan
reviewed
Aug 21, 2022
Demivan
approved these changes
Aug 22, 2022
ChrisTowles
deleted the
chris-towles/fix-junit-when-xml-in-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a error message has XML it made the junit reporter wasn't escaping when writing it to the log.
This should fix #1823
I don't love how i created
createSuiteHavingFailedTestWithXmlInErrorto have an test case and welcome feedback.