fix(reporter): correct error source position in json report #1909
+86
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind adding a snapshot test for the generated JSON? Thanks. |
|
@antfu |
antfu
reviewed
Aug 29, 2022
test/reporters/tests/json.test.ts
Outdated
| import { clearSourcePos, files } from '../src/data' | ||
|
|
||
| const no_comment: TransformResult = { | ||
| code: 'const __vite_ssr_import_0__ = await __vite_ssr_import__("vitest");\n' |
There was a problem hiding this comment.
This is probably too verbose. I am thinking to spawn a Vitest runner and read it's JSON output to snap
antfu
changed the title
antfu
approved these changes
Aug 29, 2022
auto-merge was automatically disabled
August 29, 2022 08:34
Head branch was pushed to by a user without write access
|
@antfu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #1894