fix: add possibility to filter test files by fileName

[bartoszgolebiowski]

Hello,

fix #1797

I have created PR with a new option for "node-vite".
I added to vitest config new property "fileNamePattern", it is similar to "testNamePattern"
It is responsible for skipping test files when the pattern does not match.
I added documentation for "fileNamePattern" next to "testNamePattern" property.
I added additional information for the CLI help option about the new property.
I added a test case to check if the new functionality works as expected.

To test it you can:

1. test/core/vitest.config.ts -> remove "fileNamePattern" property. -> it will fail because I added failing file-name-pattern.test.ts
2. pnpm run test -p .test -> it will fail because I added failing file-name-pattern.test.ts

[bartoszgolebiowski]

failing on check: CI / test (windows-latest, 16), examples/playwright
I think this is not related to my changes.

[sheremet-va]

I don't like basing solution on testNamePattern. We can already define a pattern for tests with include.

If you just want to add -p option to CLI, you can call this.rerunFiles with a new set of files, filtered by the new pattern.

[bartoszgolebiowski]

Hello,

I added a new folder test-skip, which is used to create the test scenario to check if filtering works correctly.
I set fileNamePattern: '/core/test/',
Due to that it will match all tests inside the test folder, and will not match tests inside the test-skip folder.
I could not find any other method to create a test for this scenario, but I am open to discuss.

According to your review, I have updated the changeFilenamePattern method to filter files array and pass results to this.rerunFiles

[sheremet-va]

According to your review, I have updated the changeFilenamePattern method to filter files array and pass results to this.rerunFiles

No, what I meant is that we don't need this property at all, because we already have include and exclude. When pressing p, we should just pass down correct files to rerunFiles.

I don't mind using regex for this.

[sheremet-va]

@bartoszgolebiowski I pushed some changes to your PR. We don't have tests for stdin right now, unfortunately tho, and creating infrastructure for it is out of scope of this PR, I think. But would be great to have this stuff tested.

I also noticed that after rerunning it doesn't update test count, can you look into that?

[bartoszgolebiowski]

Hello @sheremet-va

I added one failing test in the "skip-test" directory and new property "fileNamePattern"
in vitest.config.ts which was responsible for setting an initial value for filter 93056db#diff-644652b4f2da0d83159d02c25d7368a9480fe293826cc3314d4f25cd26672ea6L82

This filter runs all tests inside "test" directory and does not run test inside "skip-test" directory.
I can see that the new test file and logic for injecting value are gone.

To resolve it, we can still use 0fcdd52#diff-ff14f3092ee007d54e9c9f53fa4044149899b44fa12979cc92f1d182d1a2b057R45 and assigning this value to
93056db#diff-644652b4f2da0d83159d02c25d7368a9480fe293826cc3314d4f25cd26672ea6R26 and add failing test in the "skip-test" folder again.

let latestFilename = String(ctx.config.fileNamePattern || '')

BR
Bartosz Golebiowski

[sheremet-va]

To resolve it, we can still use 0fcdd52#diff-ff14f3092ee007d54e9c9f53fa4044149899b44fa12979cc92f1d182d1a2b057R45 and assigning this value to
93056db#diff-644652b4f2da0d83159d02c25d7368a9480fe293826cc3314d4f25cd26672ea6R26 and add failing test in the "skip-test" folder again.

Yes, but this doesn't actually test the interaction that user has - pressing "p" and inserting filter.

[bartoszgolebiowski]

@sheremet-va
It is true, in that case, I do not how to test this functionality.

BR

[unional]

The file name filter doesn't work at all. Using vitest 0.25.5. (during watch mode).

All tests files are still being executed.