Skip to content

feat: allow custom environments #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 4, 2022
Merged

feat: allow custom environments #1963

merged 8 commits into from
Sep 4, 2022
+230 −25

Conversation

sheremet-va
Copy link
Member

Closes #1961

@sheremet-va
feat: allow custom environments

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
f020b8f
@sheremet-va sheremet-va requested a review from antfu September 3, 2022 11:31
@sheremet-va sheremet-va mentioned this pull request Sep 3, 2022
Closed
4 tasks
@sheremet-va
chore: linting

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
aca268c
Demivan
Demivan reviewed Sep 3, 2022
View reviewed changes
Demivan
Demivan reviewed Sep 3, 2022
View reviewed changes
sheremet-va and others added 2 commits September 3, 2022 15:09
@sheremet-va @Demivan
chore: cleanup

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
40351aa 
Co-authored-by: Ivan Demchuk <ivan.demchuk@gmail.com>
@sheremet-va @Demivan
chore: cleanup

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
544cdf3 
Co-authored-by: Ivan Demchuk <ivan.demchuk@gmail.com>
antfu
antfu reviewed Sep 3, 2022
View reviewed changes
@antfu
Copy link
Member

antfu commented Sep 3, 2022 •
edited
Loading

Overall direction looks good to me 👍

@sheremet-va
chore: cleanup

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
8aee39d
@sheremet-va
docs: cleanup

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
27f947a
@sheremet-va sheremet-va requested review from antfu and Demivan September 4, 2022 05:23
Demivan
Demivan approved these changes Sep 4, 2022
View reviewed changes
sheremet-va and others added 2 commits September 4, 2022 09:23
@sheremet-va
docs: cleanup

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
487d568
@sheremet-va @Demivan
Update docs/guide/environment.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ce8926c 
Co-authored-by: Ivan Demchuk <ivan.demchuk@gmail.com>
@sheremet-va sheremet-va merged commit e393be3 into vitest-dev:main Sep 4, 2022
@sheremet-va sheremet-va deleted the feat/allow-custom-envs branch September 4, 2022 06:37
nickserv
nickserv reviewed Sep 4, 2022
View reviewed changes
Copy link
Contributor

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I got busy but thanks for working on this.

@nickserv

This comment was marked as outdated.

Sign in to view
antfu pushed a commit to poyoho/vitest that referenced this pull request Sep 4, 2022
@sheremet-va @Demivan @antfu
feat: allow custom environments (vitest-dev#1963)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
56018a8 
* feat: allow custom environments

* chore: linting

* chore: cleanup

Co-authored-by: Ivan Demchuk <ivan.demchuk@gmail.com>

* chore: cleanup

Co-authored-by: Ivan Demchuk <ivan.demchuk@gmail.com>

* chore: cleanup

* docs: cleanup

* docs: cleanup

* Update docs/guide/environment.md

Co-authored-by: Ivan Demchuk <ivan.demchuk@gmail.com>

Co-authored-by: Ivan Demchuk <ivan.demchuk@gmail.com>
@nickserv nickserv mentioned this pull request Sep 4, 2022
Closed
4 tasks
@renovate renovate bot mentioned this pull request Sep 18, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickserv nickserv

@Demivan Demivan

@antfu antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom environment support
4 participants
@sheremet-va @antfu @nickserv @Demivan