Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Junit reporter does not escape all XML tags #2140

Closed
6 tasks done
flunderpero opened this issue Oct 12, 2022 · 1 comment
Closed
6 tasks done

Regression: Junit reporter does not escape all XML tags #2140

flunderpero opened this issue Oct 12, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@flunderpero
Copy link

flunderpero commented Oct 12, 2022

Describe the bug

This seems to be a regression of #1823
With the latest version of vitest, stacktraces are not escaped properly.

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-b4w9ta?file=test/basic.test.ts

I inject the string "<anonymous>" into the error's stacktrace and it is not escaped in the Junit-XML output.

System Info

System:
    OS: macOS 12.5.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 99.88 MB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.7.0 - ~/.nvm/versions/node/v18.7.0/bin/node
    Yarn: 3.1.0 - ~/.nvm/versions/node/v18.7.0/bin/yarn
    npm: 8.18.0 - ~/.nvm/versions/node/v18.7.0/bin/npm
  Browsers:
    Chrome: 106.0.5249.103
    Firefox: 105.0.1
    Safari: 15.6.1

Used Package Manager

yarn

Validations

@sheremet-va sheremet-va added bug good first issue Good for newcomers labels Oct 28, 2022
@sheremet-va
Copy link
Member

Cannot reproduce with the latest version. I will close the issue. If you think there is still a problem, feel free to let me know.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants