Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid/Control clear-screen behaviour #2255

Closed
4 tasks done
silverwind opened this issue Nov 1, 2022 · 4 comments
Closed
4 tasks done

Avoid/Control clear-screen behaviour #2255

silverwind opened this issue Nov 1, 2022 · 4 comments

Comments

@silverwind
Copy link
Contributor

silverwind commented Nov 1, 2022

Clear and concise description of the problem

Since #2228 vitest clears the screen in both watch and non-watch mode which I find rather disturbing because it removes potentially useful information from commands that ran before.

#2070 specifically only requested the clear-screen only for watch mode so I think the implementation forgot about non-watch mode.

Suggested solution

I would suggest to never clear the screen when in non-watch mode and make the behaviour of the clear in watch mode configurable, like vite does via the clearScreen option.

Validations

@sheremet-va
Copy link
Member

Vitest already respects clearScreen option

@sheremet-va sheremet-va added the bug label Nov 2, 2022
@sheremet-va
Copy link
Member

Fixed in c3d8950

@silverwind
Copy link
Contributor Author

silverwind commented Nov 2, 2022

Thanks.

Vitest already respects clearScreen option

I don't see this option documented in either --help or on https://vitest.dev/config/. Are the docs missing?

@sheremet-va
Copy link
Member

It’s an option in Vite config (since Vitest extends Vite config, it inherits the same options), its not available ad a CLI option.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants