Restart on configuration change broken since v0.24.4

[AriPerkkio]

Describe the bug

Since #2228 the automatic restart on configuration file change in watch mode broke. vitest@0.24.3 works as expected.

By commenting out this block the crash does not happen.

vitest/packages/vitest/src/node/cli-wrapper.ts

Lines 64 to 69 in 824e18c

	// if not specified, don't run through spawn,
	// because it prints stderr messages in the wrong order compared to stdout
	if (retries <= 0) {
	await import('./cli')
	return
	}

Restarting due to config changes...

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Rejection ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
TypeError: Cannot read properties of undefined (reading 'logger')
 ❯ VerboseReporter.onCollected ../vitest/packages/vitest/dist/chunk-vite-node-externalize.fd4469d3.js:8316:46
 ❯ ../vitest/packages/vitest/dist/chunk-vite-node-externalize.fd4469d3.js:10900:51
 ❯ Vitest.report ../vitest/packages/vitest/dist/chunk-vite-node-externalize.fd4469d3.js:10898:38
 ❯ Proxy.onCollected ../vitest/packages/vitest/dist/chunk-vite-node-externalize.fd4469d3.js:7671:13
 ❯ MessagePort.<anonymous> ../vitest/packages/vitest/dist/chunk-vite-node-client.bea3705d.js:376:42
 ❯ [nodejs.internal.kHybridDispatch] node:internal/event_target:734:20
 ❯ exports.emitMessage node:internal/per_context/messageport:23:28

Reproduction

Stackblitz boilerplate without any changes: https://stackblitz.com/edit/vitest-dev-vitest-vrwfeu?file=vite.config.ts&initialPath=__vitest__

Run vitest and make a whitespace change to the configuration file.

System Info

Stackblitz

Used Package Manager

pnpm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[LeonardoRick]

I'm getting the same error!

[AriPerkkio]

This also breaks coverage reporters on restart.

When starting Vitest, the execution order is setServer -> start. On restart it is the opposite. I'm looking into whether reporters and coverage providers could be initialized in setServer or some other handle executed after it instead.

vitest/packages/vitest/src/node/core.ts

Line 58 in 8595c0e

async setServer(options: UserConfig, server: ViteDevServer) {

vitest/packages/vitest/src/node/core.ts

Line 202 in 8595c0e

async start(filters?: string[]) {

[sheremet-va]

On restart it is the opposite. I'm looking into whether reporters and coverage providers could be initialized

I think it's better to make execution order consistent between start and restart. We can move hook call, or something.