fix: don't resolve builtin Node modules #2538
Merged
+112
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheremet-va
changed the title
sheremet-va
changed the title
antfu
approved these changes
Dec 20, 2022
renovate bot
referenced
this pull request
in fwouts/previewjs
Dec 23, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vitest](https://togithub.com/vitest-dev/vitest) | [`^0.25.8` -> `^0.26.2`](https://renovatebot.com/diffs/npm/vitest/0.25.8/0.26.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.26.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.26.2) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.26.1...v0.26.2) ##### 🚀 Features - Project name - by [@​antfu](https://togithub.com/antfu) [<samp>(84f98)</samp>](https://togithub.com/vitest-dev/vitest/commit/84f98e70) ##### 🐞 Bug Fixes - Improve "isInternaRequest" check - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2541](https://togithub.com/vitest-dev/vitest/issues/2541) [<samp>(2bb9a)</samp>](https://togithub.com/vitest-dev/vitest/commit/2bb9a391) - Use correct word when printing "long-running" warning - by [@​simon-abbott](https://togithub.com/simon-abbott) in [https://github.com/vitest-dev/vitest/issues/2546](https://togithub.com/vitest-dev/vitest/issues/2546) [<samp>(8dc1c)</samp>](https://togithub.com/vitest-dev/vitest/commit/8dc1c3cb) - Pass down diff options - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2545](https://togithub.com/vitest-dev/vitest/issues/2545) [<samp>(98c94)</samp>](https://togithub.com/vitest-dev/vitest/commit/98c94e65) - **cli**: Respect inline config `dir` - by [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/2550](https://togithub.com/vitest-dev/vitest/issues/2550) [<samp>(f6b59)</samp>](https://togithub.com/vitest-dev/vitest/commit/f6b592a9) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.26.1...v0.26.2) ### [`v0.26.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.26.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.26.0...v0.26.1) ##### 🚀 Features - Add more options to configure diff output - by [@​sheremet-va](https://togithub.com/sheremet-va) and [@​dammy001](https://togithub.com/dammy001) in [https://github.com/vitest-dev/vitest/issues/2522](https://togithub.com/vitest-dev/vitest/issues/2522) [<samp>(7ae14)</samp>](https://togithub.com/vitest-dev/vitest/commit/7ae1417f) ##### 🐞 Bug Fixes - Don't resolve builtin Node modules - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2538](https://togithub.com/vitest-dev/vitest/issues/2538) [<samp>(1cbc2)</samp>](https://togithub.com/vitest-dev/vitest/commit/1cbc24dc) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.26.0...v0.26.1) ### [`v0.26.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.26.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.8...v0.26.0) ##### 🚨 Breaking Changes - **vite-node:** Rewrite how vite-node resolves id - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2463](https://togithub.com/vitest-dev/vitest/issues/2463) [<samp>(58ee8)</samp>](https://togithub.com/vitest-dev/vitest/commit/58ee8e9b) - Correctly interop nested default for external and inlined modules - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2512](https://togithub.com/vitest-dev/vitest/issues/2512) [<samp>(084e9)</samp>](https://togithub.com/vitest-dev/vitest/commit/084e929c) - If your environment is `node`, Vitest will not resolve invalid named exports (exports that are on "default" property will not magically appear as named exports), unless `deps.interopDefault` is enabled, or dependency is in `deps.inline`. This change doesn't affect `jsdom`, `happy-dom` or `edge` environments. - **web-worker:** Make web-worker implementation more compatible with spec - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2431](https://togithub.com/vitest-dev/vitest/issues/2431) [<samp>(c3a63)</samp>](https://togithub.com/vitest-dev/vitest/commit/c3a63524) - Messages are now cloned with `structuredClone`, if it's available, or fallbacks to a polyfill. - Added support for `SharedWorker` ##### 🚀 Features - Introduce a native way to set env and globals - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2515](https://togithub.com/vitest-dev/vitest/issues/2515) [<samp>(b114d)</samp>](https://togithub.com/vitest-dev/vitest/commit/b114d49f) - Add html reporter based on Vitest UI - by [@​poyoho](https://togithub.com/poyoho) and [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2444](https://togithub.com/vitest-dev/vitest/issues/2444) [<samp>(b8f34)</samp>](https://togithub.com/vitest-dev/vitest/commit/b8f34eb8) - If you have `@vitest/ui` installed, you can now use `'html'` reporter to get a [beautiful UI](https://vitest.dev/guide/ui.html) to view your test results, inspect module graph and read log messages. ##### 🐞 Bug Fixes - Allow assigning new hotContext - by [@​cometkim](https://togithub.com/cometkim) in [https://github.com/vitest-dev/vitest/issues/2524](https://togithub.com/vitest-dev/vitest/issues/2524) [<samp>(b4c43)</samp>](https://togithub.com/vitest-dev/vitest/commit/b4c43cd5) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.8...v0.26.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43MC40IiwidXBkYXRlZEluVmVyIjoiMzQuNzAuNCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
gastonfournier
referenced
this pull request
in Unleash/unleash
Dec 28, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vitest](https://togithub.com/vitest-dev/vitest) | [`0.25.7` -> `0.26.2`](https://renovatebot.com/diffs/npm/vitest/0.25.7/0.26.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.26.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.26.2) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.26.1...v0.26.2) ##### 🚀 Features - Project name - by [@​antfu](https://togithub.com/antfu) [<samp>(84f98)</samp>](https://togithub.com/vitest-dev/vitest/commit/84f98e70) ##### 🐞 Bug Fixes - Improve "isInternaRequest" check - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2541](https://togithub.com/vitest-dev/vitest/issues/2541) [<samp>(2bb9a)</samp>](https://togithub.com/vitest-dev/vitest/commit/2bb9a391) - Use correct word when printing "long-running" warning - by [@​simon-abbott](https://togithub.com/simon-abbott) in [https://github.com/vitest-dev/vitest/issues/2546](https://togithub.com/vitest-dev/vitest/issues/2546) [<samp>(8dc1c)</samp>](https://togithub.com/vitest-dev/vitest/commit/8dc1c3cb) - Pass down diff options - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2545](https://togithub.com/vitest-dev/vitest/issues/2545) [<samp>(98c94)</samp>](https://togithub.com/vitest-dev/vitest/commit/98c94e65) - **cli**: Respect inline config `dir` - by [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/2550](https://togithub.com/vitest-dev/vitest/issues/2550) [<samp>(f6b59)</samp>](https://togithub.com/vitest-dev/vitest/commit/f6b592a9) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.26.1...v0.26.2) ### [`v0.26.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.26.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.26.0...v0.26.1) ##### 🚀 Features - Add more options to configure diff output - by [@​sheremet-va](https://togithub.com/sheremet-va) and [@​dammy001](https://togithub.com/dammy001) in [https://github.com/vitest-dev/vitest/issues/2522](https://togithub.com/vitest-dev/vitest/issues/2522) [<samp>(7ae14)</samp>](https://togithub.com/vitest-dev/vitest/commit/7ae1417f) ##### 🐞 Bug Fixes - Don't resolve builtin Node modules - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2538](https://togithub.com/vitest-dev/vitest/issues/2538) [<samp>(1cbc2)</samp>](https://togithub.com/vitest-dev/vitest/commit/1cbc24dc) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.26.0...v0.26.1) ### [`v0.26.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.26.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.8...v0.26.0) ##### 🚨 Breaking Changes - **vite-node:** Rewrite how vite-node resolves id - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2463](https://togithub.com/vitest-dev/vitest/issues/2463) [<samp>(58ee8)</samp>](https://togithub.com/vitest-dev/vitest/commit/58ee8e9b) - Correctly interop nested default for external and inlined modules - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2512](https://togithub.com/vitest-dev/vitest/issues/2512) [<samp>(084e9)</samp>](https://togithub.com/vitest-dev/vitest/commit/084e929c) - If your environment is `node`, Vitest will not resolve invalid named exports (exports that are on "default" property will not magically appear as named exports), unless `deps.interopDefault` is enabled, or dependency is in `deps.inline`. This change doesn't affect `jsdom`, `happy-dom` or `edge` environments. - **web-worker:** Make web-worker implementation more compatible with spec - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2431](https://togithub.com/vitest-dev/vitest/issues/2431) [<samp>(c3a63)</samp>](https://togithub.com/vitest-dev/vitest/commit/c3a63524) - Messages are now cloned with `structuredClone`, if it's available, or fallbacks to a polyfill. - Added support for `SharedWorker` ##### 🚀 Features - Introduce a native way to set env and globals - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2515](https://togithub.com/vitest-dev/vitest/issues/2515) [<samp>(b114d)</samp>](https://togithub.com/vitest-dev/vitest/commit/b114d49f) - Add html reporter based on Vitest UI - by [@​poyoho](https://togithub.com/poyoho) and [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2444](https://togithub.com/vitest-dev/vitest/issues/2444) [<samp>(b8f34)</samp>](https://togithub.com/vitest-dev/vitest/commit/b8f34eb8) - If you have `@vitest/ui` installed, you can now use `'html'` reporter to get a [beautiful UI](https://vitest.dev/guide/ui.html) to view your test results, inspect module graph and read log messages. ##### 🐞 Bug Fixes - Allow assigning new hotContext - by [@​cometkim](https://togithub.com/cometkim) in [https://github.com/vitest-dev/vitest/issues/2524](https://togithub.com/vitest-dev/vitest/issues/2524) [<samp>(b4c43)</samp>](https://togithub.com/vitest-dev/vitest/commit/b4c43cd5) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.8...v0.26.0) ### [`v0.25.8`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.25.8) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.25.7...v0.25.8) ##### 🚀 Features - Add mts, cts files to coverage - by [@​poyoho](https://togithub.com/poyoho) and [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/2492](https://togithub.com/vitest-dev/vitest/issues/2492) [<samp>(799f9)</samp>](https://togithub.com/vitest-dev/vitest/commit/799f9a17) ##### 🐞 Bug Fixes - Don't throw unhandled error, if import was caught - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2494](https://togithub.com/vitest-dev/vitest/issues/2494) [<samp>(0a87e)</samp>](https://togithub.com/vitest-dev/vitest/commit/0a87ebb4) - **coverage**: Esbuild to preserve legal comments for ignore hints - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/2496](https://togithub.com/vitest-dev/vitest/issues/2496) [<samp>(c85ed)</samp>](https://togithub.com/vitest-dev/vitest/commit/c85edb1e) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.25.7...v0.25.8) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43My4zIiwidXBkYXRlZEluVmVyIjoiMzQuNzMuMyJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2531
Fixes #2533
Should not be a breaking change, since support is the same as Vitest: https://2ality.com/2021/12/node-protocol-imports.html