feat: tasks mode #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
commented
Dec 4, 2021
| if (t.result && t.result.error === undefined) { | ||
| log(`${' '.repeat(indent * 2)}${c.inverse(c.green(' PASS '))} ${c.green(t.name)}`) | ||
| if (runSuite && (((t.mode === 'run' && !options?.onlyMode) || t.mode === 'only') || suite.mode === 'only')) { | ||
| await runTask(t) |
There was a problem hiding this comment.
Instead of running all tasks for a suite and then reporting, I'm reporting as soon as the task is done. We need to revert this change if there was a reason for running every task first
There was a problem hiding this comment.
I think the new goal is to implement a reporter interface and decouple the printing and the runner. We indeed should print ASAP and even provide progress states.
|
Conflicts resolved, I'll see if I can send a PR with basic docs for run modes + support |
Closed
6 tasks
1 task
1 task
1 task
This was referenced Jun 26, 2023
This was referenced Jul 3, 2023
This was referenced Jul 11, 2023
1 task
This was referenced Sep 16, 2023
1 task
This was referenced Dec 19, 2023
This was referenced Jan 17, 2024
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #2 (should be merged first, or this one should not be squashed)
I don't know how to properly test only, I did that one by hand