fix(coverage): throw error if fail to load built-in provider #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
force-pushed
the
fix/error-if-missing-coverage-package
branch
from
584a12d
to
ad0c81f
Compare
sheremet-va
approved these changes
Apr 21, 2023
renovate bot
added a commit
to dermoumi/crafts
that referenced
this pull request
May 3, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vitest/coverage-istanbul](https://togithub.com/vitest-dev/vitest/tree/main/packages/coverage-istanbul#readme) ([source](https://togithub.com/vitest-dev/vitest)) | [`^0.30.1` -> `^0.31.0`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-istanbul/0.30.1/0.31.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.31.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.31.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.30.1...v0.31.0) ##### 🚨 Breaking Changes - Update mock implementation to support ESM runtime, introduce "vi.hoisted" - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3258 [<samp>(0c09a)</samp>](https://togithub.com/vitest-dev/vitest/commit/0c09a40d) - Bypass ESM import order restriction with `vi.hoisted` to run code before imports are executed: ```ts vi.hoisted(() => vi.setSystemTime(new Date(2022, 1, 1))) ``` You can also use it to pass variables to `vi.mock`: ```ts const { mockedMethod } = vi.hoisted(() => { return { mockedMethod: vi.fn() } }) vi.mocked('./path/to/module.js', () => { return { originalMethod: mockedMethod } }) ``` - Move assertion declarations to expect package - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3294 [<samp>(cf3af)</samp>](https://togithub.com/vitest-dev/vitest/commit/cf3afe2b) - The change should be minor: ```diff - declare namespace Vi { + declare module '@​vitest/expect' { interface Assertion<T = any> extends CustomMatchers<T> {} interface AsymmetricMatchersContaining extends CustomMatchers {} } ``` ##### 🚀 Features - Add repeat method to tests - by [@​samkevin1](https://togithub.com/samkevin1) in [vitest-dev/vitest#2652 [<samp>(7c8f0)</samp>](https://togithub.com/vitest-dev/vitest/commit/7c8f0ba9) - Add an option to hide skipped test lines - by [@​g4rry420](https://togithub.com/g4rry420) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2745 [<samp>(9bdb1)</samp>](https://togithub.com/vitest-dev/vitest/commit/9bdb1603) - **coverage**: Watermarks for c8 - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#3254 [<samp>(730af)</samp>](https://togithub.com/vitest-dev/vitest/commit/730af0b4) - **ui**: Add html coverage - by [@​userquin](https://togithub.com/userquin) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3071 [<samp>(e24cd)</samp>](https://togithub.com/vitest-dev/vitest/commit/e24cd9b2) - **watch**: Test run cancelling, feat: `--bail` option for cancelling test run - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#3163 [<samp>(8d460)</samp>](https://togithub.com/vitest-dev/vitest/commit/8d4606eb) ##### 🐞 Bug Fixes - Don't call global setup teardown twice - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3188 [<samp>(ba3d1)</samp>](https://togithub.com/vitest-dev/vitest/commit/ba3d1338) - Reporter to log version before provider initalizations - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#3131 [<samp>(481b1)</samp>](https://togithub.com/vitest-dev/vitest/commit/481b1fd2) - Throw an error if Vitest cannot access its internal state - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3250 [<samp>(fbb14)</samp>](https://togithub.com/vitest-dev/vitest/commit/fbb1468e) - Warning suppression broken - by [@​IceQub3](https://togithub.com/IceQub3) in [vitest-dev/vitest#3270 and [vitest-dev/vitest#3271 [<samp>(036de)</samp>](https://togithub.com/vitest-dev/vitest/commit/036de797) - Show correct diff in "toHaveBeenCalledWith" - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3289 [<samp>(19fcd)</samp>](https://togithub.com/vitest-dev/vitest/commit/19fcd8df) - Don't print esm warning, if package name is not found - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3292 [<samp>(62c14)</samp>](https://togithub.com/vitest-dev/vitest/commit/62c14cba) - Support exactOptionalPropertyTypes - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3293 [<samp>(ba81d)</samp>](https://togithub.com/vitest-dev/vitest/commit/ba81d8a3) - Don't inline vite hmr and rollup types - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3291 [<samp>(1f118)</samp>](https://togithub.com/vitest-dev/vitest/commit/1f1189bc) - **browser**: - Failing to load vitest/utils - by [@​userquin](https://togithub.com/userquin) in [vitest-dev/vitest#3190 [<samp>(78bad)</samp>](https://togithub.com/vitest-dev/vitest/commit/78bad4ab) - **coverage**: - `thresholdAutoUpdate` to work with `perFile` - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#3182 [<samp>(29eeb)</samp>](https://togithub.com/vitest-dev/vitest/commit/29eebf65) - Throw error if fail to load built-in provider - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#3217 [<samp>(0a287)</samp>](https://togithub.com/vitest-dev/vitest/commit/0a2875e3) - Stackblitz hangs with c8 - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#3225 [<samp>(d9fda)</samp>](https://togithub.com/vitest-dev/vitest/commit/d9fda2a1) - C8 to ignore vite's generated helpers - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#3241 [<samp>(21942)</samp>](https://togithub.com/vitest-dev/vitest/commit/21942db0) - Workspaces c8 source maps - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#3226 [<samp>(efce3)</samp>](https://togithub.com/vitest-dev/vitest/commit/efce3b4d) - **docs**: - Correct typo and broken link to WebdriverIO - by [@​nathanbabcock](https://togithub.com/nathanbabcock) in [vitest-dev/vitest#3275 [<samp>(c7da1)</samp>](https://togithub.com/vitest-dev/vitest/commit/c7da155f) - **spy**: - Update to set initial implementation through normal logic - by [@​Codex-](https://togithub.com/Codex-) in [vitest-dev/vitest#3260 and [vitest-dev/vitest#3263 [<samp>(c759a)</samp>](https://togithub.com/vitest-dev/vitest/commit/c759a9aa) - **vite-node**: - Circular imports - by [@​antfu](https://togithub.com/antfu) in [vitest-dev/vitest#3196 [<samp>(cbb59)</samp>](https://togithub.com/vitest-dev/vitest/commit/cbb593a8) - Add missing `import.meta.hot.send` mock - by [@​antfu](https://togithub.com/antfu) [<samp>(b1624)</samp>](https://togithub.com/vitest-dev/vitest/commit/b1624db5) - **vitest**: - Also check for vite relative to vitest package - by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) and [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#3274 [<samp>(a3393)</samp>](https://togithub.com/vitest-dev/vitest/commit/a3393b15) - **watch**: - Run test files when added to filesystem - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#3189 [<samp>(7b2c8)</samp>](https://togithub.com/vitest-dev/vitest/commit/7b2c81bc) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.30.1...v0.31.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/dermoumi/crafts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42OS4zIiwidXBkYXRlZEluVmVyIjoiMzUuNjkuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue's reproduction case the
@vitest/coverage-c8does not providedefaultexport which causescoverageModuleto beundefined. This makescore.tsto think that coverage is disabled.As solution we should fail whole process if default export is missing.