feat(cli): graceful close of vitest in watch mode #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: d5d1b33 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61cb35b46533950007a5ec92 😎 Browse the preview: https://deploy-preview-349--vitest-dev.netlify.app |
patak-dev
approved these changes
Dec 28, 2021
dammy001
reviewed
Dec 28, 2021
| @@ -248,8 +250,17 @@ class Vitest { | |||
| } | |||
|
|
|||
| async close() { | |||
There was a problem hiding this comment.
it is not required that async functions contain an await and close returns a promise, so the contract of async is there.
And while it is not strictly needed here i think it doesn't hurt and shows the async nature of the implementation.
|
|
|
another 6 consecutives runs with latest changes with no memory error reported on windows |
JakeGinnivan
pushed a commit
to JakeGinnivan/vitest
that referenced
this pull request
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that vite buildEnd hook is called and resources are cleaned up gracefully