Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): fixture needs to be initialized for each test #4250

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 5, 2023

Description

Fixes: #4165 (comment)
Fixes: #4251
This PR will change initialize fixtures behaviour, the fixture needs to be initialized for each test.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 29ee8be
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/651f4838fd125c0008bd18b7

@Dunqing Dunqing mentioned this pull request Oct 5, 2023
6 tasks
@sheremet-va sheremet-va merged commit 76a9329 into vitest-dev:main Oct 6, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom fixture teardown isn't called fixtures are not preserved between beforeEach and test
2 participants