Skip to content

fix(vitest): correctly hoist vi.hoisted if assigned #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Oct 10, 2023

Description

Currently vi.hoisted is not hoisted if it's assigned to another variable and there are no vi.mock/vi.unmock inside the file.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sorry, something went wrong.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 025ad83
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/652520fa9508ac00080f40f8

@sheremet-va sheremet-va merged commit ff93a57 into vitest-dev:main Oct 10, 2023
@sheremet-va sheremet-va deleted the fix/assign-hoisted branch October 10, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant