Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't bundle import from rollup #4392

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

sheremet-va
Copy link
Member

Description

Fixes #4391

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@stackblitz
Copy link

stackblitz bot commented Oct 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 4a58c58
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/653ee5fdc155a10008cdac27
😎 Deploy Preview https://deploy-preview-4392--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wojtekmaj
Copy link
Contributor

Pardon my ignorance, but how is this going to solve the issue, if the problematic import has not been removed? Am I missing something?

@sheremet-va
Copy link
Member Author

Pardon my ignorance, but how is this going to solve the issue, if the problematic import has not been removed? Am I missing something?

There is no import from rollup in the source code. It’s added by dts plugin.

@sheremet-va sheremet-va merged commit 3b58487 into vitest-dev:main Oct 30, 2023
15 of 16 checks passed
@sheremet-va sheremet-va deleted the fix/rollup-in-types branch October 30, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript error when using Yarn PnP
2 participants