Skip to content

fix(types): defineWorkspace fix intellisense and report type errors #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(types): defineWorkspace fix intellisense and report type errors #4743

merged 1 commit into from
Dec 15, 2023
+77 −8

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Dec 13, 2023 •
edited
Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sorry, something went wrong.

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 28efb56
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/657a076005b96b0008a25275

@AriPerkkio AriPerkkio changed the title fix(config): workspace config breaks with multiple entries fix(config): defineWorkspace breaks with multiple entries Dec 13, 2023
@AriPerkkio AriPerkkio changed the title fix(config): defineWorkspace breaks with multiple entries fix(config): defineWorkspace fix intellisense and report type errors Dec 13, 2023
@AriPerkkio AriPerkkio force-pushed the fix/workspace-config-types branch from 95739ac to a706d89 Compare December 13, 2023 19:31
@AriPerkkio AriPerkkio changed the title fix(config): defineWorkspace fix intellisense and report type errors fix(types): defineWorkspace fix intellisense and report type errors Dec 13, 2023
@AriPerkkio
fix(config): defineWorkspace fix intellisense and report type errors

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
28efb56
@AriPerkkio AriPerkkio force-pushed the fix/workspace-config-types branch from a706d89 to 28efb56 Compare December 13, 2023 19:34
@sheremet-va sheremet-va merged commit 9cc3668 into vitest-dev:main Dec 15, 2023
@AriPerkkio AriPerkkio deleted the fix/workspace-config-types branch December 15, 2023 10:09
@renovate renovate bot mentioned this pull request Dec 21, 2023
Merged
1 task
@renovate renovate bot mentioned this pull request Apr 30, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AriPerkkio @sheremet-va