Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest): use file instead of id for HMR #4938

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Jan 11, 2024

Description

Related #4785

This PR fixes a case when tests failed to rerun if non-main file of a module was updated in jsdom environment. Unfortunately, it's not possible to fix the error when the first edit is ignored because chokidar just doesn't trigger the event, so it's an upstream problem.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sorry, something went wrong.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 56de1a8
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65a0171438d38000079b36d5

@sheremet-va sheremet-va changed the title fox(vitest): use file instead of id for HMR fix(vitest): use file instead of id for HMR Jan 11, 2024
@sheremet-va sheremet-va merged commit ca76f45 into vitest-dev:main Jan 11, 2024
@sheremet-va sheremet-va deleted the fix/wztch-mode-filepath branch January 11, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant