Skip to content

fix(vitest): remove excessive listeners when running without isolation, don't reset the state #5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Feb 7, 2024

Description

We don't reset the state anymore because it doesn't do anything (the state is on the global object, so resetting the reference makes no difference for gc). The same can be said for the environment.

I also noticed Vitest sometimes shows a warning that too many listeners are applied - I think we worked around it by silencing the error with setMaxListeners which should never be the solution 😄

Closes #5071

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sorry, something went wrong.

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 95a90f1
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65c35e14beed8c0008a0e074

@sheremet-va sheremet-va merged commit b607f1e into vitest-dev:main Feb 7, 2024
@sheremet-va sheremet-va deleted the fix/remove-listener branch February 7, 2024 11:17
@sheremet-va sheremet-va added this to the 1.3.0 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'transformMode')
1 participant