New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: collect coverage using node inspector (fix #378) #584
Conversation
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: b195108 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61ed248e3bec4d0007cf20b3 😎 Browse the preview: https://deploy-preview-584--vitest-dev.netlify.app |
@antfu @patak-dev Can you check this out? |
1b2b2d0
to
b195108
Compare
Let's give it a try! |
@antfu Coverage of fluent-vue did not change fluent-vue/fluent-vue#749 (comment) - that is good, and #378 is fixed. Only downside is that you now get messages in console when running coverage:
Will check if I can disable this output. |
Cannot disable this message, NodeJs will always print it. |
… (vitest-dev#584)" This reverts commit de33284.
Fixes #378
For now this is just a proof of concept.
Tested on fluent-vue and vitest reports incorrect coverage for it.With detailed coverage enabled it is much better now.It still reports wrong code lines though.edit:
Coverage is almost the same as it would be if Vitest waited for all coverage files to finish writing to disk. Tested on fluent-vue.
With "wait for coverage to be written" fix:
This implementation: