fix: don't rerun more then needed in watch mode (fix #442) #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #442
What was happening with #442 is that
onChange
was called for a file. That adds it tochangedTests
. After thatonChange
was triggered for a file in.idea
folder. And becausechangedTests
is not empty another rerun was scheduled.vitest/packages/vitest/src/node/core.ts
Lines 285 to 287 in 2509e06
Fixed by returning from
handleFileChanged
indication whetherchangedTests
was mutated and rerun it needed.