feat: move matcher types to Vi namespace #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 2ad0d05 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61ebf346a3a82a00086901a8 😎 Browse the preview: https://deploy-preview-608--vitest-dev.netlify.app |
sheremet-va
commented
Jan 22, 2022
| @@ -16,8 +16,6 @@ export * from './integrations/vi' | |||
| export * from './types' | |||
| export * from './api/types' | |||
|
|
|||
| export type { Spy, SpyFn } from 'tinyspy' | |||
There was a problem hiding this comment.
these are internal types
| namespace Chai { | ||
| interface ExpectStatic extends AsymmetricMatchersContaining { | ||
| <T>(actual: T, message?: string): VitestAssertion<T> | ||
| namespace Vi { |
There was a problem hiding this comment.
allows for:
namespace Vi {
interface Assertion {
customerAssertion(): void;
}
}chai augmentations should still work
namespace Chai {
interface Assertion {
customerAssertion(): void;
}
}
Vi.Assertion['customerAssertion'] // exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using
Vinamespace since as I saw from others in discord, this is preferred way to use vitest