Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): consistent type-only file handling #6183

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

AriPerkkio
Copy link
Member

Description

During #5457 the changes of #5328 should have been reverted. The #5457 implements type-only file detection in proper way while #5328 was mostly a work-around since good solution was not available back then.

Files containing just types will show up in coverage report. But they will not have uncovered lines like they did before #5457.

Tip

To hide empty files from coverage reporters use reporter options:

{
  coverage: {
    reporter: [
      ['text', { 'skipEmpty': true }],
      ['html', { 'skipEmpty': true }],
    ]
  }
}

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage report does not include types-only TS files
2 participants