Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bold help shortcut #628

Merged
merged 2 commits into from Jan 25, 2022
Merged

feat: bold help shortcut #628

merged 2 commits into from Jan 25, 2022

Conversation

btea
Copy link
Contributor

@btea btea commented Jan 25, 2022

No description provided.

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: 45d96ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61efe957028fc10008da8882

😎 Browse the preview: https://deploy-preview-628--vitest-dev.netlify.app

@antfu
Copy link
Member

antfu commented Jan 25, 2022

Can you provide more context? I found it looks fine to me
image

@btea
Copy link
Contributor Author

btea commented Jan 25, 2022

It looks like this on my side. My system is windows 10, and the vscode version is 1.63.2.

image

@antfu antfu merged commit a629db6 into vitest-dev:main Jan 25, 2022
@btea btea deleted the bold-key branch January 25, 2022 12:35
@btea
Copy link
Contributor Author

btea commented Jan 25, 2022

I found that press enter also to rerun all tests. Maybe should add it like this press a/enter to return all tests? @antfu

${c.bold('Watch Usage')}
${keys.map(i => c.dim(' press ') + c.reset(i[0]) + c.dim(` to ${i[1]}`)).join('\n')}
${c.bold(' Watch Usage')}
${keys.map(i => c.dim(' press ') + c.bold(c.reset(i[0])) + c.dim(` to ${i[1]}`)).join('\n')}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c.bold(c.reset(i[0])) doesn't seem to bold words, maybe we should use c.reset(c.bold(i[0])).

I did the following test
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants