Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ignore cypress files in coverage by default #651

Merged
merged 1 commit into from Feb 3, 2022
Merged

feat: ignore cypress files in coverage by default #651

merged 1 commit into from Feb 3, 2022

Conversation

cexbrayat
Copy link
Contributor

Projects using Cypress often have e2e spec files in a cypress directory that currently needs to be manually ignored.
This is the case for create-vue projects for example.

This commit adds cypress/** to the default excludes of the code coverage config.

@cexbrayat
feat: ignore cypress files in coverage by default
631edee 
Projects using Cypress often have e2e spec files in a `cypress` directory that currently needs to be manually ignored.
This is the case for `create-vue` projects for example.

This commit adds `cypress/**` to the default excludes of the code coverage config.
@netlify
Copy link

netlify bot commented Jan 28, 2022 •
edited

✔️ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: 631edee

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61f3be8ab630160008b21d1a

😎 Browse the preview: https://deploy-preview-651--vitest-dev.netlify.app

@patak-dev
Copy link
Member

Should we exclude it as **/cypress/**? This is what we currently do in the exclude default value https://vitest.dev/config/#exclude

@cexbrayat
Copy link
Contributor Author

@patak-dev I went with the same pattern the other coverage excludes are using but it could make sense. We should probably change all of them in that case no (maybe in a following PR)?

@patak-dev
Copy link
Member

As you wish, I think that at least the ones using **/xxx/** in exclude should use the same pattern here

@DerYeger
Copy link
Member

As you wish, I think that at least the ones using **/xxx/** in exclude should use the same pattern here

This could also eliminate duplicates like the various test/* excludes.

@antfu antfu merged commit ce68e2b into vitest-dev:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cexbrayat @patak-dev @DerYeger @antfu