globalSetup executed twice with --ui

[dominikg]

Describe the bug

If you add a globalSetup file and run vitest --ui the setup function is executed twice

Reproduction

https://stackblitz.com/edit/node-arkh2h?devtoolsheight=33&file=globalSetup.ts

run npm run test observe 'globalSetup' is logged twice

System Info

Binaries:
    Node: 16.13.2 - ~/.nvm/versions/node/v16.13.2/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.2/bin/yarn
    npm: 8.3.2 - ~/.nvm/versions/node/v16.13.2/bin/npm
  Browsers:
    Chrome: 97.0.4692.71
    Firefox: 96.0
  npmPackages:
    vitest: workspace:* => 0.2.7

Used Package Manager

pnpm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[dominikg]

it looks like vite patches httpServer.listen https://github.com/vitejs/vite/blob/3311686bbcc12481495374c58cd1bc054d2429b8/packages/vite/src/node/server/index.ts#L579

to call buildStart, and vitest calls buildStart explicitly here https://github.com/vitest-dev/vitest/blob/main/packages/vitest/src/node/create.ts#L26 and then if --ui is set httpServer.listen is called by https://github.com/vitest-dev/vitest/blob/main/packages/vitest/src/node/create.ts#L29

i'm not really sure why vitest is calling buildStart manually, my gut feeling is that this should be handled by vite internally.

cc @antfu

[patak-dev]

buildStart is needed before calling other hooks as some plugins are using this hook to initialize caches (the hook is also called when re-building in build watch mode so it is a good place to place this code instead of when constructing the plugin).

I think we should avoid the manual call to buildStart if --ui is enabled.